Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not validate inputs when disabled #37

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Do not validate inputs when disabled #37

merged 1 commit into from
Aug 8, 2023

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Aug 8, 2023 •
edited
Loading

what

  • Replace variable validations with precondition

why

  • Variable validation cannot take other variables into account. With precondition, we can allow invalid inputs when the module is disabled.

references

@Nuru Nuru added the patch A minor, backward compatible change label Aug 8, 2023
@Nuru Nuru requested review from aknysh, milldr and Benbentwo August 8, 2023 23:29
@Nuru Nuru requested review from a team as code owners August 8, 2023 23:29
@Nuru Nuru requested review from Gowiem and korenyoni August 8, 2023 23:29
@Nuru
Copy link
Contributor Author

Nuru commented Aug 8, 2023

/terratest

@Nuru Nuru enabled auto-merge (squash) August 8, 2023 23:33
@Nuru Nuru merged commit 5d8145a into main Aug 8, 2023
@Nuru Nuru deleted the preconditions branch August 8, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milldr milldr milldr approved these changes

@aknysh aknysh Awaiting requested review from aknysh

@Benbentwo Benbentwo Awaiting requested review from Benbentwo

@Gowiem Gowiem Awaiting requested review from Gowiem Gowiem is a code owner automatically assigned from cloudposse/contributors

@korenyoni korenyoni Awaiting requested review from korenyoni korenyoni is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nuru @milldr